Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sue updates #79

Merged
merged 13 commits into from
Feb 10, 2025
Merged

Sue updates #79

merged 13 commits into from
Feb 10, 2025

Conversation

Sue-Holding
Copy link
Contributor

updated views user-dashboard, user-settings, admin-dashboard, admin-settings
create components - buttons - approve, edit, delete, create
create components - forms and tables display
create components - sidebars - user / admin
create components - profile image display and settings form
create components - pending review table display
create components - watchlist gallery display for profile page

Copy link
Contributor

@TryFailCryTryAgain TryFailCryTryAgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Thru the comments and make the changes,
But regarding majority of the code, it looks good

resources/views/admin-dashboard.blade.php Outdated Show resolved Hide resolved
@@ -1,113 +1,27 @@
@extends('layouts.app')

@section('content')
<body class="h-screen bg-gray-900">
<body>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion

The body element is already started inside the header, and ends inside the footer tags, that comes with the "layouts.app" Change the body element into a div element

@@ -0,0 +1,3 @@
<button type="submit" class="bg-blue-600 text-black px-6 py-3 rounded hover:bg-blue-700 w-full">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the spacing regarding this code

@@ -1,52 +1,32 @@
@extends('layouts.app')

@section('content')
<body class="h-screen bg-gray-900">
<body>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body element is already started inside the header, and ends inside the footer tags, that comes with the "layouts.app" Change the body element into a div element

@@ -3,121 +3,32 @@
@section('content')
<body>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body element is already started inside the header, and ends inside the footer tags, that comes with the "layouts.app" Change the body element into a div element

Copy link
Contributor

@TryFailCryTryAgain TryFailCryTryAgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets stress test it in dev

@TryFailCryTryAgain TryFailCryTryAgain merged commit 87ca668 into dev Feb 10, 2025
@TryFailCryTryAgain TryFailCryTryAgain deleted the sue-updates branch February 10, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants